pdf broken encoding reader #522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…takes too much time), changed imports
NastyBoget
reviewed
Apr 7, 2025
NastyBoget
reviewed
Apr 7, 2025
NastyBoget
reviewed
Apr 7, 2025
NastyBoget
reviewed
Apr 7, 2025
NastyBoget
reviewed
Apr 7, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Apr 7, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Apr 7, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Show resolved
Hide resolved
NastyBoget
reviewed
Apr 7, 2025
NastyBoget
reviewed
Apr 7, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Show resolved
Hide resolved
|
Please look to the logs of test pipelines - they all should pass before merge |
oksidgy
reviewed
Apr 8, 2025
.../pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/data/models/default_models/eng.h5
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ders/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_broken_encoding_reader.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
| call_classifier=False)) | ||
| return lines, tables, page.attachments, [] | ||
|
|
||
| def __handle_page(self, page: PDFPage, page_number: int, path: str, |
There was a problem hiding this comment.
it is dublicated code of dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdfminer_reader/pdfminer_extractor.py with different that you use own layout (pass own layout ). Try to use code of dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdfminer_reader/pdfminer_extractor.py with small changes of code of pdfminer_extractor.py.
For example in file dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdfminer_reader/pdfminer_extractor.py:
- do pubic function
def __handle_page(...)->def handle_page(...) - added small changes into code:
def handle_page(self, page: PDFPage, page_number: int, path: str, parameters: ParametersForParseDoc, Layout: Optional[LTPage] = None) -> PageWithBBox:
...
if not layout:
layout = device.get_result()
...
So, by adding these small changes you will get rid of 300 lines of duplicate code!
There was a problem hiding this comment.
Почему добавили еще одну функцию handle_page, если эта функция уже есть? Ее достаточно просто изменить как показано в примере выше. А то снова код дублируется, получается две почти одинаковые функции handle_page в одном классе
oksidgy
reviewed
Apr 8, 2025
...s/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/pdf_worker/pdf_text_correcter.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/model.py
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/model.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/functions.py
Outdated
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
...ers/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/ffwrapper/fontforge_wrapper.py
Show resolved
Hide resolved
oksidgy
reviewed
Apr 8, 2025
dedoc/readers/pdf_reader/pdf_txtlayer_reader/pdf_broken_encoding_reader/config.py
Outdated
Show resolved
Hide resolved
…pdfminer_extractor, added function handle_page(...) to pdfminer_extractor to use in my reader
…ction to tempfile
|
problems with imports (numpy) during running tests installs numpy 2.0.2 but required numpy<2.0. Runned even on dedoc without my commits on devolopment branch, but problem remains. Please check |
oksidgy
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader to extract code from PDF with complex background using information from PDF
added my code from project needed to extract text:
added script to scripts dir to extract text using reader
edited index.html, api_args, manager_config, gitignore and requirements